linux-kernel - Re:[PATCH RESEND] drm/rockchip: Unregister platform drivers in reverse order

Open Source and information security mailing list archives

Message-ID: <3649004a.1f69.191445d79dc.Coremail.andyshrk@163.com>
Date: Mon, 12 Aug 2024 10:14:22 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Cristian Ciocaltea" <cristian.ciocaltea@...labora.com>
Cc: "Sandy Huang" <hjc@...k-chips.com>, 
	Heiko Stübner <heiko@...ech.de>, 
	"Andy Yan" <andy.yan@...k-chips.com>, 
	"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>, 
	"Maxime Ripard" <mripard@...nel.org>, 
	"Thomas Zimmermann" <tzimmermann@...e.de>, 
	"David Airlie" <airlied@...il.com>, 
	"Daniel Vetter" <daniel@...ll.ch>, 
	"Sean Paul" <seanpaul@...omium.org>, 
	"Jeffy Chen" <jeffy.chen@...k-chips.com>, 
	"Andrzej Hajda" <andrzej.hajda@...el.com>, 
	"Mark Yao" <markyao0591@...il.com>, kernel@...labora.com, 
	dri-devel@...ts.freedesktop.org, 
	linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re:[PATCH RESEND] drm/rockchip: Unregister platform drivers in
 reverse order

Hi Cristian,

At 2024-08-08 19:58:02, "Cristian Ciocaltea" <cristian.ciocaltea@...labora.com> wrote:
>Move rockchip_drm_platform_driver unregistration after its sub-drivers,
>which ensures all drivers are unregistered in the reverse order used
>when they were registered.

Would you please provied some detail information about how to reproduce this
issue this patch try to fix？Or some kernel log when this issue   triggered。
>
>Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.")
>Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
>---
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>index 44d769d9234d..ca7b07503fbe 100644
>--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>@@ -528,10 +528,9 @@ static int __init rockchip_drm_init(void)
> 
> static void __exit rockchip_drm_fini(void)
> {
>-	platform_driver_unregister(&rockchip_drm_platform_driver);
>-
> 	platform_unregister_drivers(rockchip_sub_drivers,
> 				    num_rockchip_sub_drivers);
>+	platform_driver_unregister(&rockchip_drm_platform_driver);
> }
> 
> module_init(rockchip_drm_init);
>
>---
>base-commit: 1eb586a9782cde8e5091b9de74603e0a8386b09e
>change-id: 20240702-rk-drm-fix-unreg-9f3f29996a00
>-- 
>Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@...ts.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives