linux-kernel - Re: [PATCH v6 2/2] mm: support large folios swap-in for zRAM-like devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zrn0TS9vyfbQW8Yq@infradead.org>
Date: Mon, 12 Aug 2024 04:38:53 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Barry Song <21cnbao@...il.com>
Cc: Christoph Hellwig <hch@...radead.org>, akpm@...ux-foundation.org,
	linux-mm@...ck.org, baolin.wang@...ux.alibaba.com,
	chrisl@...nel.org, david@...hat.com, hannes@...xchg.org,
	hughd@...gle.com, kaleshsingh@...gle.com, kasong@...cent.com,
	linux-kernel@...r.kernel.org, mhocko@...e.com, minchan@...nel.org,
	nphamcs@...il.com, ryan.roberts@....com, senozhatsky@...omium.org,
	shakeel.butt@...ux.dev, shy828301@...il.com, surenb@...gle.com,
	v-songbaohua@...o.com, willy@...radead.org, xiang@...nel.org,
	ying.huang@...el.com, yosryahmed@...gle.com,
	Chuanhua Han <hanchuanhua@...o.com>
Subject: Re: [PATCH v6 2/2] mm: support large folios swap-in for zRAM-like
 devices

On Mon, Aug 12, 2024 at 08:53:06PM +1200, Barry Song wrote:
> On Mon, Aug 12, 2024 at 8:27 PM Christoph Hellwig <hch@...radead.org> wrote:
> I assume you mean the below?
> 
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> static struct folio *alloc_swap_folio(struct vm_fault *vmf)
> {
> }
> #else
> static struct folio *alloc_swap_folio(struct vm_fault *vmf)
> {
> }
> #endif

Yes.

> If so, this is fine to me. the only reason I am using the current
> pattern is that i am trying to follow the same pattern with
> 
> static struct folio *alloc_anon_folio(struct vm_fault *vmf)
> {
>         struct vm_area_struct *vma = vmf->vma;
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> #endif
>         ...
> }
> 
> Likely we also want to change that one?

It would be nice to fix that a well, probably noy in this series,
though.