linux-kernel - Re: [PATCH net-next v3 1/6] netdevice: convert private flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26db3c81-5da6-483a-b9d0-6c9fcda5c5c0@intel.com>
Date: Mon, 12 Aug 2024 14:09:31 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Kees Cook <kees@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
	<dsahern@...nel.org>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Andrew Lunn
	<andrew@...n.ch>, Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 1/6] netdevice: convert private flags >
 BIT(31) to bitfields

From: Jakub Kicinski <kuba@...nel.org>
Date: Fri, 9 Aug 2024 22:27:55 -0700

> On Thu,  8 Aug 2024 17:27:52 +0200 Alexander Lobakin wrote:
>> + *	@priv_flags_fast: both hotpath private flags as bits and as bitfield
>> + *			booleans combined, only to assert cacheline placement
>> + *	@priv_flags:	flags invisible to userspace defined as bits, see
>> + *			enum netdev_priv_flags for the definitions
> 
> The kdoc scripts says:
> 
> include/linux/netdevice.h:2392: warning: Excess struct member 'priv_flags_fast' description in 'net_device'
> 
> I thought you sent a kernel-doc patch during previous cycle to fix this,
> or was that for something else?

Oh crap.
The patch I sent expands struct_group_tagged() only.
If I do the same for the regular struct_group(), there'll clearly be a
ton of new warnings.
I think I'll just submit v4 with removing this line from the kdoc?

Thanks,
Olek