linux-kernel - Re: [PATCH 1/1] x86/ioremap: Use is_vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJrpu5mm2j4U55wmcDTcFGBG41YrWpeg=reX2sWP_ajCpBLNOw@mail.gmail.com>
Date: Mon, 12 Aug 2024 15:10:05 +0300
From: Max R <max8rr8@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: Alistair Popple <apopple@...dia.com>, Dan Williams <dan.j.williams@...el.com>, 
	dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org, 
	linux-kernel@...r.kernel.org, x86@...nel.org, jhubbard@...dia.com, 
	Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH 1/1] x86/ioremap: Use is_vmalloc_addr in iounmap

> So this lacks a Fixes tag and some deep analysis of similar potential
> problems. While at it please use func() notation for functions. In the
> middle of a sentence iounmap does not immediately stand out, but
> iounmap() does. It's documented ...

Yep, will do, not sure which commit to attribute to Fixes though. Probably:

41e94a851304 add devm_memremap_pages

As it seems to be the first one that might cause high_memory to overlap
with VMALLOC.

> The correct helper to use is is_ioremap_addr, as in the generic
> iounmap implementation.  This won't matter for x86 currently, but
> it clearly documents what the code is doing.

And will update that too. The patch is over a year old, and at the time of
submission the generic implementation used is_vmalloc_addr.

Best regards,
Max