linux-kernel - Re: [PATCH v2 6/8] arm64: dts: renesas: r9a09g057: Add WDT0-WDT3 nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8sR1Lu1FYMQbDXzzi19ShF-RLkwirF-51aWp1bjwG8LXw@mail.gmail.com>
Date: Mon, 12 Aug 2024 13:31:58 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 6/8] arm64: dts: renesas: r9a09g057: Add WDT0-WDT3 nodes

Hi Biju,

On Mon, Aug 12, 2024 at 1:25 PM Biju Das <biju.das.jz@...renesas.com> wrote:
>
> Hi Prabhakar,
>
> > -----Original Message-----
> > From: Prabhakar <prabhakar.csengg@...il.com>
> > Sent: Sunday, August 11, 2024 9:50 PM
> > Subject: [PATCH v2 6/8] arm64: dts: renesas: r9a09g057: Add WDT0-WDT3 nodes
> >
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Add WDT0-WDT3 nodes to RZ/V2H(P) ("R9A09G057") SoC DTSI.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > v1->v2
> > - New patch
> > ---
> >  arch/arm64/boot/dts/renesas/r9a09g057.dtsi | 44 ++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > index 435b1f4e7d38..7f4e8ad9b0a5 100644
> > --- a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > @@ -184,6 +184,17 @@ scif: serial@...01400 {
> >                       status = "disabled";
> >               };
> >
> > +             wdt0: watchdog@...00400 {
> > +                     compatible = "renesas,r9a09g057-wdt";
> > +                     reg = <0 0x11c00400 0 0x400>;
> > +                     clocks = <&cpg CPG_MOD 75>,
> > +                              <&cpg CPG_MOD 76>;
> > +                     clock-names = "pclk", "oscclk";
> > +                     resets = <&cpg 117>;
> > +                     power-domains = <&cpg>;
> > +                     status = "disabled";
> > +             };
> > +
> >               ostm4: timer@...00000 {
> >                       compatible = "renesas,r9a09g057-ostm", "renesas,ostm";
> >                       reg = <0x0 0x12c00000 0x0 0x1000>;
> > @@ -224,6 +235,28 @@ ostm7: timer@...03000 {
> >                       status = "disabled";
> >               };
> >
> > +             wdt2: watchdog@...00000 {
> > +                     compatible = "renesas,r9a09g057-wdt";
> > +                     reg = <0 0x13000000 0 0x400>;
> > +                     clocks = <&cpg CPG_MOD 79>,
> > +                              <&cpg CPG_MOD 80>;
> > +                     clock-names = "pclk", "oscclk";
> > +                     resets = <&cpg 119>;
> > +                     power-domains = <&cpg>;
> > +                     status = "disabled";
> > +             };
>
> I guess same group(all wdt together) arranged together?? Not sure.
>
I think Geert prefers it to be sorted based on unit address. So I'll
let Geert make a decision on this (and the rest of the similar patches
where nodes are sorted based on unit address and not grouped based on
IP).

Cheers,
Prabhakar