[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <cf46ea4b-425d-4505-a029-e071b1885d8e@amd.com>
Date: Mon, 12 Aug 2024 09:08:24 -0400
From: Hamza Mahfooz <hamza.mahfooz@....com>
To: Daniel Yang <danielyangkang@...il.com>, skhan@...uxfoundation.org
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kerneldoc: Fix two missing newlines in drm_connector.c
On 8/8/24 23:23, Daniel Yang wrote:
> Fix the unexpected indentation errors.
>
> drm_connector.c has some kerneldoc comments that were missing newlines.
> This results in the following warnings when running make htmldocs:
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2344: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2346: ERROR: Unexpected indentation. [docutils]
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2368: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2381: ERROR: Unexpected indentation. [docutils]
>
> Signed-off-by: Daniel Yang <danielyangkang@...il.com>
Applied, thanks!
> ---
>
> Notes:
> v2: added "Fix the unexpected indentation errors" line to description.
>
> drivers/gpu/drm/drm_connector.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 80e239a6493..fc35f47e284 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -2342,7 +2342,9 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
> *
> * Default:
> * The behavior is driver-specific.
> + *
> * BT2020_RGB:
> + *
> * BT2020_YCC:
> * User space configures the pixel operation properties to produce
> * RGB content with Rec. ITU-R BT.2020 colorimetry, Rec.
> @@ -2366,6 +2368,7 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
> * range.
> * The variants BT2020_RGB and BT2020_YCC are equivalent and the
> * driver chooses between RGB and YCbCr on its own.
> + *
> * SMPTE_170M_YCC:
> * BT709_YCC:
> * XVYCC_601:
> @@ -2378,6 +2381,7 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
> * DCI-P3_RGB_Theater:
> * RGB_WIDE_FIXED:
> * RGB_WIDE_FLOAT:
> + *
> * BT601_YCC:
> * The behavior is undefined.
> *
--
Hamza
Powered by blists - more mailing lists