linux-kernel - [PATCH v1] pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812070108.100923-1-hal.feng@starfivetech.com>
Date: Mon, 12 Aug 2024 15:01:08 +0800
From: Hal Feng <hal.feng@...rfivetech.com>
To: Linus Walleij <linus.walleij@...aro.org>,
	Conor Dooley <conor@...nel.org>,
	Emil Renner Berthing <emil.renner.berthing@...onical.com>,
	Jianlong Huang <jianlong.huang@...rfivetech.com>,
	Hal Feng <hal.feng@...rfivetech.com>
Cc: linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v1] pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register

A mistake was made in level trigger register configuration. Correct it.

Fixes: 447976ab62c5 ("pinctrl: starfive: Add StarFive JH7110 sys controller driver")
Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
---

Hi,

When we tested some modules that use gpio level trigger, we found
the current level trigger register configuration was set wrong.
Submit this patch to correct.

Best regards,
Hal

---
 drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
index 4ce080caa233..1d0d6c224c10 100644
--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
@@ -793,12 +793,12 @@ static int jh7110_irq_set_type(struct irq_data *d, unsigned int trigger)
 	case IRQ_TYPE_LEVEL_HIGH:
 		irq_type  = 0;    /* 0: level triggered */
 		edge_both = 0;    /* 0: ignored */
-		polarity  = mask; /* 1: high level */
+		polarity  = 0;    /* 0: high level */
 		break;
 	case IRQ_TYPE_LEVEL_LOW:
 		irq_type  = 0;    /* 0: level triggered */
 		edge_both = 0;    /* 0: ignored */
-		polarity  = 0;    /* 0: low level */
+		polarity  = mask; /* 1: low level */
 		break;
 	default:
 		return -EINVAL;

base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba
-- 
2.43.2