[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240812133032.115134-8-w@uter.be>
Date: Mon, 12 Aug 2024 15:20:42 +0200
From: Wouter Verhelst <w@...r.be>
To: Josef Bacik <josef@...icpanda.com>,
Jens Axboe <axboe@...nel.dk>
Cc: Wouter Verhelst <w@...r.be>,
Eric Blake <eblake@...hat.com>,
Damien Le Moal <dlemoal@...nel.org>,
linux-block@...r.kernel.org,
nbd@...er.debian.org,
linux-kernel@...r.kernel.org,
Eric Blake <eblake@...hat.Com>
Subject: [PATCH v4 3/3] nbd: correct the maximum value for discard sectors
The version of the NBD protocol implemented by the kernel driver
currently has a 32 bit field for length values. As the NBD protocol uses
bytes as a unit of length, length values larger than 2^32 bytes cannot
be expressed.
Update the max_hw_discard_sectors field to match that.
Signed-off-by: Wouter Verhelst <w@...r.be>
Fixes: 268283244c0f ("nbd: use the atomic queue limits API in nbd_set_size")
Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
Cc: Eric Blake <eblake@...hat.Com>
---
drivers/block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index fdcf0bbedf3b..235ab5f59608 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -339,7 +339,7 @@ static int __nbd_set_size(struct nbd_device *nbd, loff_t bytesize,
lim = queue_limits_start_update(nbd->disk->queue);
if (nbd->config->flags & NBD_FLAG_SEND_TRIM)
- lim.max_hw_discard_sectors = UINT_MAX;
+ lim.max_hw_discard_sectors = UINT_MAX >> SECTOR_SHIFT;
else
lim.max_hw_discard_sectors = 0;
if (!(nbd->config->flags & NBD_FLAG_SEND_FLUSH)) {
--
2.43.0
Powered by blists - more mailing lists