linux-kernel - [REGRESSION] critical target error, bisected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zrog4DYXrirhJE7P@debian.local>
Date: Mon, 12 Aug 2024 15:49:04 +0100
From: Chris Bainbridge <chris.bainbridge@...il.com>
To: fengli@...rtx.com, hch@....de, martin.petersen@...cle.com
Cc: axboe@...nel.dk, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [REGRESSION] critical target error, bisected

Hello,

Machine is HP Aero 13 laptop. The following error appears in 6.11-rc3
when booted from USB drive:

[  195.647081] sd 0:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[  195.647093] sd 0:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current]
[  195.647096] sd 0:0:0:0: [sda] tag#0 Add. Sense: Invalid command operation code
[  195.647099] sd 0:0:0:0: [sda] tag#0 CDB: Write same(16) 93 08 00 00 00 00 04 dd 42 f8 00 00 2d 48 00 00
[  195.647101] critical target error, dev sda, sector 81609464 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 0

This error appears on two different laptops with different USB drives.


Bisect result:

f874d7210d882cb1c58a8e3da66f61cdc63cd4b4 is the first bad commit
commit f874d7210d882cb1c58a8e3da66f61cdc63cd4b4
Author: Li Feng <fengli@...rtx.com>
Date:   Thu Jul 18 16:07:22 2024 +0800

    scsi: sd: Keep the discard mode stable

    There is a scenario where a large number of discard commands are issued
    when the iscsi initiator connects to the target and then performs a session
    rescan operation. There is a time window, most of the commands are in UNMAP
    mode, and some discard commands become WRITE SAME with UNMAP.

    The discard mode has been negotiated during the SCSI probe. If the mode is
    temporarily changed from UNMAP to WRITE SAME with UNMAP, an I/O ERROR may
    occur because the target may not implement WRITE SAME with UNMAP. Keep the
    discard mode stable to fix this issue.

    Signed-off-by: Li Feng <fengli@...rtx.com>
    Link: https://lore.kernel.org/r/20240718080751.313102-2-fengli@smartx.com
    Reviewed-by: Christoph Hellwig <hch@....de>
    Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>

 drivers/scsi/sd.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

#regzbot introduced: f874d7210d882cb1c58a8e3da66f61cdc63cd4b4