linux-kernel - Re: [PATCH v2 0/7] Add input voltage suppliers for PMIC MCP16502 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <172347672887.922611.11316946762732938797.robh@kernel.org>
Date: Mon, 12 Aug 2024 09:33:33 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Andrei Simion <andrei.simion@...rochip.com>
Cc: alexandre.belloni@...tlin.com, krzk+dt@...nel.org, 
 nicolas.ferre@...rochip.com, claudiu.beznea@...on.dev, broonie@...nel.org, 
 devicetree@...r.kernel.org, conor+dt@...nel.org, 
 linux-kernel@...r.kernel.org, lgirdwood@...il.com, 
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 0/7] Add input voltage suppliers for PMIC MCP16502
 regulators


On Mon, 12 Aug 2024 16:52:24 +0300, Andrei Simion wrote:
> In this series of patches, support for the *-supply property [1]  is added
> (correlated with supply_name [2]) from the core regulator.
> Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
> Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064
> 
> I modified the mcp16502.c driver and the dts that use this PMIC.
> We added these improvements to provide a complete description of the board power scheme.
> 
> Snippet (as an example) from /sys/kernel/debug/regulator/regulator_summary
> (for at91-sama7g5ek):
>  # cat regulator_summary
>  regulator                      use open bypass  opmode voltage current     min     max
> ---------------------------------------------------------------------------------------
>  regulator-dummy                  1    0      0 unknown     0mV     0mA     0mV     0mV
>  5V_MAIN                          6    6      0 unknown  5000mV     0mA  5000mV  5000mV
>     VDD_IO                        5    4      0  normal  3300mV     0mA  3300mV  3300mV
>        e1208000.mmc-vqmmc         1                                 0mA     0mV     0mV
>        e1208000.mmc-vmmc          1                                 0mA  3300mV  3400mV
>        e1204000.mmc-vmmc          1                                 0mA  3300mV  3400mV
>        VDDOUT25                   3    2      0 unknown  2500mV     0mA  2500mV  2500mV
>           e1000000.adc-vref       1                                 0mA     0mV     0mV
>           e1000000.adc-vddana     1                                 0mA     0mV     0mV
>     VDD_DDR                       1    0      0  normal  1350mV     0mA  1350mV  1350mV
>     VDD_CORE                      1    0      0  normal  1150mV     0mA  1150mV  1150mV
>     VDD_OTHER                     2    1      0  normal  1050mV     0mA  1050mV  1250mV
>        cpu0-cpu                   1                                 0mA  1050mV  1225mV
>     LDO1                          2    1      0 unknown  1800mV     0mA  1800mV  1800mV
>        e1204000.mmc-vqmmc         1                                 0mA     0mV     0mV
>     LDO2
> 
> -------------------------------------------------------------------------------------------
> 
> Changelog:
> 
> v1 -> v2:
>  - drop (lvin|pvin[1-4])-supply from each regulators sub-node
>  - add voltage input supply documentation in the yaml schema
>  - add lvin-supply, pvin[1-4]-supply to PMIC node
> 
> Andrei Simion (7):
>   regulator: mcp16502: Add supplier for regulators
>   regulator: dt-bindings: microchip,mcp16502: Add voltage input supply
>     documentation
>   ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes
>   ARM: dts: microchip: at91-sama7g54_curiosity: Add reg_5v to supply
>     PMIC nodes
>   ARM: dts: microchip: at91-sama5d2_icp: Add reg_5v to supply PMIC nodes
>   ARM: dts: microchip: at91-sama5d27_wlsom1: Add reg_5v to supply PMIC
>     nodes
>   ARM: dts: microchip: sama5d29_curiosity: Add reg_5v to supply PMIC
>     nodes
> 
>  .../regulator/microchip,mcp16502.yaml         | 20 +++++++++++++++++++
>  .../dts/microchip/at91-sama5d27_wlsom1.dtsi   | 13 ++++++++++++
>  .../dts/microchip/at91-sama5d29_curiosity.dts | 13 ++++++++++++
>  .../boot/dts/microchip/at91-sama5d2_icp.dts   | 13 ++++++++++++
>  .../dts/microchip/at91-sama7g54_curiosity.dts | 13 ++++++++++++
>  .../arm/boot/dts/microchip/at91-sama7g5ek.dts | 13 ++++++++++++
>  drivers/regulator/mcp16502.c                  | 17 ++++++++--------
>  7 files changed, 94 insertions(+), 8 deletions(-)
> 
> 
> base-commit: 9e6869691724b12e1f43655eeedc35fade38120c
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y microchip/at91-sama5d29_curiosity.dtb microchip/at91-sama5d2_icp.dtb microchip/at91-sama7g54_curiosity.dtb microchip/at91-sama7g5ek.dtb' for 20240812135231.43744-1-andrei.simion@...rochip.com:

arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/chipid@...20000: failed to match any schema with compatible: ['microchip,sama7g5-chipid']
arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/mmc@...0c000: failed to match any schema with compatible: ['microchip,sama7g5-sdhci', 'microchip,sam9x60-sdhci']
arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/mmc@...0c000: failed to match any schema with compatible: ['microchip,sama7g5-sdhci', 'microchip,sam9x60-sdhci']