linux-kernel - Re: [PATCH v2 1/2] dt-bindings: pinctrl: Add rk3576 pinctrl bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240812-decibel-abdomen-90354e0ad4e6@spud>
Date: Mon, 12 Aug 2024 17:13:28 +0100
From: Conor Dooley <conor@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: linux-kernel@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>, linux-gpio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: Add rk3576 pinctrl bindings

On Fri, Aug 09, 2024 at 01:53:16PM -0400, Detlev Casanova wrote:
> On Friday, 9 August 2024 10:58:38 EDT Conor Dooley wrote:
> > On Thu, Aug 08, 2024 at 12:39:55PM -0400, Detlev Casanova wrote:
> > > Add the compatible string as well as the optional rockchip,sys-grf field.
> > 
> > Optional for all rockchip devices supported by this binding, or just the
> > one you're adding?
> 
> It is only optionally used by rk3576. I can add it in an 'if:', or update the 
> description with somthing like "It is used on rk3576 for i3c software 
> controlled weak pull-up"

And if/else that restricts it to where it is available please.

> 
> > > Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> > > ---
> > > 
> > >  .../devicetree/bindings/pinctrl/rockchip,pinctrl.yaml      | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> > > b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml index
> > > 20e806dce1ecb..cd527ccc9e6bf 100644
> > > --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> > > +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> > > 
> > > @@ -45,6 +45,7 @@ properties:
> > >        - rockchip,rk3368-pinctrl
> > >        - rockchip,rk3399-pinctrl
> > >        - rockchip,rk3568-pinctrl
> > > 
> > > +      - rockchip,rk3576-pinctrl
> > > 
> > >        - rockchip,rk3588-pinctrl
> > >        - rockchip,rv1108-pinctrl
> > >        - rockchip,rv1126-pinctrl
> > > 
> > > @@ -54,6 +55,12 @@ properties:
> > >      description:
> > >        The phandle of the syscon node for the GRF registers.
> > > 
> > > +  rockchip,sys-grf:
> > > +    $ref: /schemas/types.yaml#/definitions/phandle
> > > +    description:
> > > +      The phandle of the syscon node for the SYS GRF registers.
> > > +      It is used for i3c software controlled weak pull-up.
> > > +
> > > 
> > >    rockchip,pmu:
> > >      $ref: /schemas/types.yaml#/definitions/phandle
> > >      description:
> 
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)