linux-kernel - Re: [PATCH v9 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKG+dMJjPXrWiQ8qZ7yfpdX3R22ntKRBawYZWTaW_9GWA@mail.gmail.com>
Date: Tue, 13 Aug 2024 08:17:05 -0600
From: Rob Herring <robh@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Aurelien Jarno <aurelien@...el32.net>, Olivia Mackall <olivia@...enic.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Dragan Simic <dsimic@...jaro.org>, 
	Uwe Kleine-König <ukleinek@...ian.org>, 
	Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Francesco Dolcini <francesco.dolcini@...adex.com>, Ard Biesheuvel <ardb@...nel.org>, 
	linux-crypto@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x

On Tue, Jul 30, 2024 at 10:11 AM Daniel Golle <daniel@...rotopia.org> wrote:
>
> From: Aurelien Jarno <aurelien@...el32.net>
>
> Include the just added Rockchip RNG driver for RK356x SoCs and
> enable it on RK3568.
>
> Signed-off-by: Aurelien Jarno <aurelien@...el32.net>
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3568.dtsi |  4 ++++
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 10 ++++++++++
>  2 files changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index f1be76a54ceb0..2a6ca20e607fd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -257,6 +257,10 @@ power-domain@...568_PD_PIPE {
>         };
>  };
>
> +&rng {
> +       status = "okay";
> +};
> +
>  &usb_host0_xhci {
>         phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
>         phy-names = "usb2-phy", "usb3-phy";
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> index 4690be841a1cd..d160a23fd4959 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -1113,6 +1113,16 @@ sdhci: mmc@...10000 {
>                 status = "disabled";
>         };
>
> +       rng: rng@...88000 {
> +               compatible = "rockchip,rk3568-rng";
> +               reg = <0x0 0xfe388000 0x0 0x4000>;
> +               clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>;
> +               clock-names = "core", "ahb";
> +               resets = <&cru SRST_TRNG_NS>;
> +               reset-names = "reset";

This adds a new warning:

rng@...88000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+'