linux-kernel - Re: [PATCH 1/1] spi: dt-bindings: convert spi-sc18is602.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL2HAeS5BWsmJRzeJb1b7nXgB92KsGe87tT5-LeYmaeyQ@mail.gmail.com>
Date: Tue, 13 Aug 2024 08:24:28 -0600
From: Rob Herring <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, "open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] spi: dt-bindings: convert spi-sc18is602.txt to yaml format

On Mon, Aug 12, 2024 at 2:30 PM Frank Li <Frank.Li@....com> wrote:
>
> Convert binding doc spi-sc18is602.txt (I2C to SPI bridge) to yaml.
>
> Additional change:
> - ref spi-controller.yaml
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
> /soc/i2c@...0000/i2c-mux@...i2c@...2c-mux@...i2c@...pi@28: failed to match any schema with compatible: ['nxp,sc18is602b']
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  .../devicetree/bindings/spi/nxp,sc18is.yaml   | 52 +++++++++++++++++++
>  .../devicetree/bindings/spi/spi-sc18is602.txt | 23 --------
>  2 files changed, 52 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/nxp,sc18is.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-sc18is602.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/nxp,sc18is.yaml b/Documentation/devicetree/bindings/spi/nxp,sc18is.yaml
> new file mode 100644
> index 0000000000000..8a5d45d976984
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/nxp,sc18is.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/nxp,sc18is.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP SC18IS602/SCIS603 I2C to SPI bridge

SCIS603 or SC18IS603?

> +
> +maintainers:
> +  - Frank Li <Frank.Li@....com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,sc18is602
> +      - nxp,sc18is602b
> +      - nxp,sc18is603
> +
> +  reg:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 7372000
> +    description:
> +      external oscillator clock frequency. If not specified, the SC18IS602
> +      default frequency (7372000) will be used.

Drop prose that the schema says already.

With those fixes,

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>

> The clock-frequency
> +      property is relevant and needed only if the chip has an external
> +      oscillator (SC18IS603).
> +
> +allOf:
> +  - $ref: spi-controller.yaml#
> +
> +unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        spi@28 {
> +            compatible = "nxp,sc18is603";
> +            reg = <0x28>;
> +            clock-frequency = <14744000>;
> +        };
> +    };
> +
> diff --git a/Documentation/devicetree/bindings/spi/spi-sc18is602.txt b/Documentation/devicetree/bindings/spi/spi-sc18is602.txt
> deleted file mode 100644
> index 02f9033270a24..0000000000000
> --- a/Documentation/devicetree/bindings/spi/spi-sc18is602.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -NXP SC18IS602/SCIS603
> -
> -Required properties:
> -       - compatible : Should be one of
> -               "nxp,sc18is602"
> -               "nxp,sc18is602b"
> -               "nxp,sc18is603"
> -       - reg: I2C bus address
> -
> -Optional properties:
> -       - clock-frequency : external oscillator clock frequency. If not
> -         specified, the SC18IS602 default frequency (7372000) will be used.
> -
> -The clock-frequency property is relevant and needed only if the chip has an
> -external oscillator (SC18IS603).
> -
> -Example:
> -
> -       sc18is603@28 {
> -               compatible = "nxp,sc18is603";
> -               reg = <0x28>;
> -               clock-frequency = <14744000>;
> -       }
> --
> 2.34.1
>