linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: x1e80100: Add USB Multiport controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b337ce5e-78f8-4ecf-a270-2d2a29e6df5b@kernel.org>
Date: Tue, 13 Aug 2024 16:35:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konradybcio@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Wesley Cheng <quic_wcheng@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>,
 linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Krishna Kurapati <quic_kriskura@...cinc.com>,
 Konrad Dybcio <quic_kdybcio@...cinc.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e80100: Add USB Multiport
 controller

On 13/08/2024 16:09, Konrad Dybcio wrote:
> On 10.08.2024 2:48 PM, Krzysztof Kozlowski wrote:
>> On 09/08/2024 15:18, Konrad Dybcio wrote:
>>> X1E80100 has a multiport controller with 2 HS (eUSB) and 2 SS PHYs
>>> attached to it. It's commonly used for USB-A ports and internally
>>> routed devices. Configure it to support such functionality.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>
>> You have from and SoB mismatch. This was sent some odd way, because both
>> b4 and git send-email would produce correct From field.
> 
> So, I'm:
> 
> - sending from @kernel because it has a good email server
> - authoring from @quicinc because that's my employer
> - sending some older @linaro patches because I made them before
>   switching jobs and it's only fair to do so like this
> (and I sometimes reply from @gmail because thunderbird works funnily)

This is all fine, but you created commit with one identity and signed
off with other. That's not fine.

> 
> I noticed locally that if you switch emails & edit author too often, git
> gets confused and `git show` Author: / `git send` From: don't get updated
> properly, but if you do git format-patch, the resulting file has what you
> would expect..
> 
> Should I resend this?

Yes, so there will be proper From field with proper author matching at
least one SoBs.

Best regards,
Krzysztof