linux-kernel - Re: [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240813080245.5e5c6657@kernel.org>
Date: Tue, 13 Aug 2024 08:02:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ratheesh Kannoth <rkannoth@...vell.com>
Cc: Vinicius Costa Gomes <vinicius.gomes@...el.com>,
 <intel-wired-lan@...ts.osuosl.org>, <daiweili@...il.com>,
 <sasha.neftin@...el.com>, <richardcochran@...il.com>, <kurt@...utronix.de>,
 <anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts
 for 82580

On Tue, 13 Aug 2024 09:42:53 +0530 Ratheesh Kannoth wrote:
> On 2024-08-10 at 05:53:02, Vinicius Costa Gomes (vinicius.gomes@...el.com) wrote:
> > @@ -6960,31 +6960,48 @@ static void igb_extts(struct igb_adapter *adapter, int tsintr_tt)
> >  static void igb_tsync_interrupt(struct igb_adapter *adapter)
> >  {
> >  	struct e1000_hw *hw = &adapter->hw;
> > -	u32 tsicr = rd32(E1000_TSICR);
> > +	u32 ack = 0, tsicr = rd32(E1000_TSICR);  
> nit: reverse xmas tree.

Please read the last paragraph below and disseminate this information
among your colleagues at Marvell.

  Reviewer guidance
  -----------------

  Reviewing other people's patches on the list is highly encouraged,
  regardless of the level of expertise. For general guidance and
  helpful tips please see :ref:`development_advancedtopics_reviews`.

  It's safe to assume that netdev maintainers know the community and
  the level of expertise of the reviewers. The reviewers should not be
  concerned about their comments impeding or derailing the patch flow.

  Less experienced reviewers are highly encouraged to do more in-depth
  review of submissions and not focus exclusively on trivial or
  subjective matters like code formatting, tags etc.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#reviewer-guidance