linux-kernel - Re: XFS mount timeout in linux-6.9.11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240813152530.GF6051@frogsfrogsfrogs>
Date: Tue, 13 Aug 2024 08:25:30 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Dave Chinner <david@...morbit.com>,
	Anders Blomdell <anders.blomdell@...il.com>,
	linux-xfs@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chandan Babu R <chandan.babu@...cle.com>
Subject: Re: XFS mount timeout in linux-6.9.11

On Tue, Aug 13, 2024 at 04:59:25PM +0200, Christoph Hellwig wrote:
> On Tue, Aug 13, 2024 at 07:19:28PM +1000, Dave Chinner wrote:
> > In hindsight, this was a wholly avoidable bug - a single patch made
> > two different API modifications that only differed by a single
> > letter, and one of the 23 conversions missed a single letter. If
> > that was two patches - one for the finobt conversion, the second for
> > the inobt conversion, the bug would have been plainly obvious during
> > review....
> 
> Maybe we should avoid identifiers that close anyway :)
> 
> The change looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

Looks good to me too
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D