linux-kernel - Re: [PATCH v2] hwmon: chipcap2: drop cc2_disable() in the probe and return dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <95a73570-0ea9-4396-866e-ffb6fc8a2ba0@roeck-us.net>
Date: Tue, 13 Aug 2024 08:53:07 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: chipcap2: drop cc2_disable() in the probe and
 return dev_err_probe()

On Tue, Aug 13, 2024 at 12:59:53AM +0200, Javier Carrasco wrote:
> There is no need to actively disable a regulator that has not been
> enabled by the driver, which makes the call to cc2_disable() in the
> probe function meaningless, because the probe function never enables
> the device's dedicated regulator.
> 
> Once the call to cc2_disable() is dropped, the error paths can directly
> return dev_err_probe() in all cases.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Applied.

Thanks,
Guenter