linux-kernel - Re: [PATCH] hwmon: (nct6775) add G15CF to ASUS WMI monitoring list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c1c6785-b994-486d-a255-8c8bd8080eb1@roeck-us.net>
Date: Tue, 13 Aug 2024 08:55:19 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Denis Pauk <pauk.denis@...il.com>
Cc: jdelvare@...e.com, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, attila@...op.one
Subject: Re: [PATCH] hwmon: (nct6775) add G15CF to ASUS WMI monitoring list

On Mon, Aug 12, 2024 at 06:26:38PM +0300, Denis Pauk wrote:
> Boards G15CF has got a nct6775 chip, but by default there's no use of it
> because of resource conflict with WMI method.
> 
> This commit adds such board to the WMI monitoring list.

Please read the documentation for proper patch descriptions.
Specifically,

> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.

I'll fix that up, but please keep it in mind for future patches.

Applied,

Thanks,
Guenter

> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Signed-off-by: Denis Pauk <pauk.denis@...il.com>
> Tested-by: Attila <attila@...op.one>
> ---
>  drivers/hwmon/nct6775-platform.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
> index 9aa4dcf4a6f3..096f1daa8f2b 100644
> --- a/drivers/hwmon/nct6775-platform.c
> +++ b/drivers/hwmon/nct6775-platform.c
> @@ -1269,6 +1269,7 @@ static const char * const asus_msi_boards[] = {
>  	"EX-B760M-V5 D4",
>  	"EX-H510M-V3",
>  	"EX-H610M-V3 D4",
> +	"G15CF",
>  	"PRIME A620M-A",
>  	"PRIME B560-PLUS",
>  	"PRIME B560-PLUS AC-HES",