linux-kernel - Re: [PATCH v2 2/2] iio: imu: smi240: imu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <703979cd-c189-41c0-a61c-eb7e90e225e6@kernel.org>
Date: Tue, 13 Aug 2024 17:57:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jianping.Shen@...bosch.com, jic23@...nel.org, lars@...afoo.de,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 dima.fedrau@...il.com, marcelo.schmitt1@...il.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Christian.Lorenz3@...bosch.com,
 Ulrike.Frauendorf@...bosch.com, Kai.Dolde@...bosch.com
Subject: Re: [PATCH v2 2/2] iio: imu: smi240: imu driver

On 09/08/2024 13:16, Jianping.Shen@...bosch.com wrote:
> +
> +MODULE_AUTHOR("Markus Lochmann <markus.lochmann@...bosch.com>");
> +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@...bosch.com>");
> +MODULE_DESCRIPTION("Bosch SMI240 driver");
> +MODULE_LICENSE("Dual BSD/GPL");

Let's be clear here: if you bothered to look at your module, you would
see that it is duplicated. I judged by code review and questioned it.
This should lead you to double and triple check. But instead of
double-checking, you engage in long discussion with reviewer. Sorry,
that's wasting my time. Your job is to check it, if you got comments on
this, not mine.

Please carefully read upstreaming guides/presentations and which
mistakes to avoid. Hint: wasting reviewer's time.

NAK.

Best regards,
Krzysztof