linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: Create COW inode from parent dentry for atomic write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACOAw_y7g6CGCDB4NG7Y-+cg2niYxg4NVpcm5eg717j45GowtQ@mail.gmail.com>
Date: Tue, 13 Aug 2024 10:32:34 -0700
From: Daeho Jeong <daeho43@...il.com>
To: Yeongjin Gil <youngjin.gil@...sung.com>
Cc: jaegeuk@...nel.org, chao@...nel.org, daehojeong@...gle.com, 
	Sungjong Seo <sj1557.seo@...sung.com>, linux-kernel@...r.kernel.org, 
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: Create COW inode from parent dentry for
 atomic write

On Tue, Aug 13, 2024 at 12:34 AM Yeongjin Gil <youngjin.gil@...sung.com> wrote:
>
> The i_pino in f2fs_inode_info has the previous parent's i_ino when inode
> was renamed, which may cause f2fs_ioc_start_atomic_write to fail.
> If file_wrong_pino is true and i_nlink is 1, then to find a valid pino,
> we should refer to the dentry from inode.
>
> To resolve this issue, let's get parent inode using parent dentry
> directly.
>
> Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
> Reviewed-by: Sungjong Seo <sj1557.seo@...sung.com>
> Reviewed-by: Sunmin Jeong <s_min.jeong@...sung.com>
> Signed-off-by: Yeongjin Gil <youngjin.gil@...sung.com>
> ---
>  fs/f2fs/file.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index fba8b5f216f9..1eae123f0315 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2127,7 +2127,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate)
>         struct mnt_idmap *idmap = file_mnt_idmap(filp);
>         struct f2fs_inode_info *fi = F2FS_I(inode);
>         struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
> -       struct inode *pinode;
>         loff_t isize;
>         int ret;
>
> @@ -2178,15 +2177,10 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate)
>         /* Check if the inode already has a COW inode */
>         if (fi->cow_inode == NULL) {
>                 /* Create a COW inode for atomic write */
> -               pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> -               if (IS_ERR(pinode)) {
> -                       f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> -                       ret = PTR_ERR(pinode);
> -                       goto out;
> -               }
> +               struct dentry *dentry = file_dentry(filp);
> +               struct inode *dir = d_inode(dentry->d_parent);
>
> -               ret = f2fs_get_tmpfile(idmap, pinode, &fi->cow_inode);
> -               iput(pinode);
> +               ret = f2fs_get_tmpfile(idmap, dir, &fi->cow_inode);
>                 if (ret) {
>                         f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
>                         goto out;
> --
> 2.40.1
>

Reviewed-by: Daeho Jeong <daehojeong@...gle.com>

Thanks,

>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel