linux-kernel - Re: [PATCH v2 1/1] selftests: net: af_unix: convert param to const char* in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240813192241.11560-1-kuniyu@amazon.com>
Date: Tue, 13 Aug 2024 12:22:41 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <mtodorovac69@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <shuah@...nel.org>
Subject: Re: [PATCH v2 1/1] selftests: net: af_unix: convert param to const char* in __recvpair() to fix warning

From: Mirsad Todorovac <mtodorovac69@...il.com>
Date: Tue, 13 Aug 2024 18:20:06 +0200
> GCC 13.2.0 reported warning about (void *) being used as a param where (char *)
> is expected:
[...]
> As Simon suggested, all calls to __recvpair() have char * as expected_buf param, so
> it is safe to change param type from (const void *) to (const char *), which silences
> the warning.
> 
> Fixes: d098d77232c37 ("selftest: af_unix: Add msg_oob.c.")
> Reported-by: Mirsad Todorovac <mtodorovac69@...il.com>

Usually Reported-by is not needed if it's same with SOB.

and the same feedback to v1.

Abhinav posted a fix earlier.

https://lore.kernel.org/netdev/20240812191122.1092806-1-jain.abhinav177@gmail.com/

Thanks