linux-kernel - Re: [PATCH 1/4] workqueue: Make wq_affn_dfl_set() use wq_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zru2wILO6RwB1d-u@slm.duckdns.org>
Date: Tue, 13 Aug 2024 09:40:48 -1000
From: Tejun Heo <tj@...nel.org>
To: Lai Jiangshan <jiangshanlai@...il.com>
Cc: linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH 1/4] workqueue: Make wq_affn_dfl_set() use
 wq_online_cpumask

Hello,

On Thu, Aug 08, 2024 at 12:23:32PM +0800, Lai Jiangshan wrote:
> > @@ -6909,18 +6909,16 @@ static int wq_affn_dfl_set(const char *val, const struct kernel_param *kp)
> >         if (affn == WQ_AFFN_DFL)
> >                 return -EINVAL;
> >
> > -       cpus_read_lock();
> >         mutex_lock(&wq_pool_mutex);
> >
> >         wq_affn_dfl = affn;
> >
> >         list_for_each_entry(wq, &workqueues, list) {
> > -               for_each_online_cpu(cpu)
> > +               for_each_cpu(cpu, wq_online_cpumask)
> >                         unbound_wq_update_pwq(wq, cpu);
> >         }
> 
> I think it should be for_each_possible_cpu() for updating the pwqs.

Can you send a patch?

Thanks.

-- 
tejun