linux-kernel - Re: [PATCH v6 01/10] media: venus: Use flex array for hfi_session_release_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3352aa92-6c50-45c6-b5a7-215e359bdf0c@suse.de>
Date: Wed, 14 Aug 2024 00:38:50 +0300
From: Stanimir Varbanov <svarbanov@...e.de>
To: Ricardo Ribalda <ribalda@...omium.org>,
 Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Hans Verkuil <hverkuil-cisco@...all.nl>, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 01/10] media: venus: Use flex array for
 hfi_session_release_buffer_pkt

Hi Ricardo,

On 8/13/24 15:31, Ricardo Ribalda wrote:
> Replace the old style single element array with a flex array. We do not
> allocate this structure, so the size change should not be an issue.
> 
> This fixes the following cocci warning:
> drivers/media/platform/qcom/venus/hfi_cmds.h:204:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> Acked-by: Vikash Garodia <quic_vgarodia@...cinc.com>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Could you inverse the order of the tags, please. "Signed-off-by" must be
first and then the others.

All patches in the series has this issue.

~Stan