linux-kernel - [PROBLEM] mm/vmstat.c:34:12: error: ‘vmstat_late_init_done’ defined but not used [-Werror=unused-variable]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b604b19d-c548-4795-adb7-3d0736b8b560@alu.unizg.hr>
Date: Wed, 14 Aug 2024 00:03:34 +0200
From: Mirsad Todorovac <mtodorovac69@...il.com>
To: linux-mm@...ck.org
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 Saurabh Sengar <ssengar@...ux.microsoft.com>
Subject: [PROBLEM] mm/vmstat.c:34:12: error: ‘vmstat_late_init_done’ defined but not used [-Werror=unused-variable]

Hi, all,

Now, the "randconfig" seed KCONFIG_SEED=0x44AB31A6 revealed another bug:

mm/vmstat.c:34:12: error: ‘vmstat_late_init_done’ defined but not used [-Werror=unused-variable]
   34 | static int vmstat_late_init_done;
      |            ^~~~~~~~~~~~~~~~~~~~~

Apparently, it is obviously wrong because it is used below:

Fixes: ef534a0d51984 ("mm/vmstat: defer the refresh_zone_stat_thresholds after all CPUs bringu")

#ifdef .. #endif forest might be better documented, but this small fix makes it running
again:

-----------------------------------------------------><----------------------------------
diff --git a/mm/vmstat.c b/mm/vmstat.c
index e361c2b3a8bc..85b3fc0084a8 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -31,7 +31,10 @@

 #include "internal.h"

+#ifdef CONFIG_SMP
 static int vmstat_late_init_done;
+#endif /* CONFIG_SMP */
+
 #ifdef CONFIG_NUMA
 int sysctl_vm_numa_stat = ENABLE_NUMA_STAT;

--

It eliminates -Werror=unused-variable and compile passes at least:

  CC      kernel/sys.o
  CC      mm/vmstat.o
  AR      init/built-in.a

Hope thi s helps.

Best regards,
Mirsad Todorovac