linux-kernel - Re: [PATCH 0/3] arm64: dts: qcom: sc8280xp: enable WLAN and Bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXuJqj5s0wQniS44F9o-KzWO5mO-sKOfkdkRRyhPpJOMotebA@mail.gmail.com>
Date: Tue, 13 Aug 2024 18:57:35 -0500
From: Steev Klimaszewski <steev@...i.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 0/3] arm64: dts: qcom: sc8280xp: enable WLAN and Bluetooth

On Tue, Aug 13, 2024 at 3:38 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> On Tue, Aug 13, 2024 at 10:12 PM Steev Klimaszewski <steev@...i.org> wrote:
> >
> > Hi Bartosz,
> >
> > On Tue, Aug 13, 2024 at 2:07 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > >
> > > This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> > > For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> > > correctly modelled wiring between them. For the X13s, we rework existing
> > > nodes so that they align with the new DT bindings contract.
> > >
> > > Bartosz Golaszewski (2):
> > >   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
> > >   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
> > >
> > > Konrad Dybcio (1):
> > >   arm64: dts: qcom: sc8280xp-crd: enable wifi
> > >
> > >  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
> > >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
> > >  2 files changed, 255 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> > >
> > What does this patchset depend on?  I'm assuming I'm missing something
> > in my config as I've tried to test this patchset and I end up with the
> > wifi and bluetooth being deferred on my Thinkpad X13s
> >
> > [   18.655330] pci 0006:01:00.0: deferred probe pending: pci: wait for
> > supplier /wcn6855-pmu/regulators/ldo9
> > [   18.655347] serial serial0-0: deferred probe pending: serial: wait
> > for supplier /wcn6855-pmu/regulators/ldo9
> > steev@...n:~$ sudo cat /sys/kernel/debug/devices_deferred
> > 0006:01:00.0    pci: wait for supplier /wcn6855-pmu/regulators/ldo9
> > serial0-0    serial: wait for supplier /wcn6855-pmu/regulators/ldo9
>
> On Tue, 13 Aug 2024 at 22:12, Steev Klimaszewski <steev@...i.org> wrote:
> >
> > Hi Bartosz,
> >
> > On Tue, Aug 13, 2024 at 2:07 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > >
> > > This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> > > For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> > > correctly modelled wiring between them. For the X13s, we rework existing
> > > nodes so that they align with the new DT bindings contract.
> > >
> > > Bartosz Golaszewski (2):
> > >   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
> > >   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
> > >
> > > Konrad Dybcio (1):
> > >   arm64: dts: qcom: sc8280xp-crd: enable wifi
> > >
> > >  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
> > >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
> > >  2 files changed, 255 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> > >
> > What does this patchset depend on?  I'm assuming I'm missing something
> > in my config as I've tried to test this patchset and I end up with the
> > wifi and bluetooth being deferred on my Thinkpad X13s
> >
> > [   18.655330] pci 0006:01:00.0: deferred probe pending: pci: wait for
> > supplier /wcn6855-pmu/regulators/ldo9
> > [   18.655347] serial serial0-0: deferred probe pending: serial: wait
> > for supplier /wcn6855-pmu/regulators/ldo9
> > steev@...n:~$ sudo cat /sys/kernel/debug/devices_deferred
> > 0006:01:00.0    pci: wait for supplier /wcn6855-pmu/regulators/ldo9
> > serial0-0    serial: wait for supplier /wcn6855-pmu/regulators/ldo9
>
> Hi Steev!
>
> There's a bunch of driver changes and some fixes needed for this to
> work that I sent later. I also sent out DT bindings updates for it. I
> decided to target relevant maintainers with smaller chunks because I
> have had more luck getting patches upstream this way than when sending
> big series with everything in them. Given that QCom patches take ages
> to get picked up, I figured the driver changes will be in next by
> then.
>
> Your best approach would be to use the public integration branch from
> my tree[1] or the one rebased on top of Johan's tree[2].
>
> Bart
>
> [1] https://git.codelinaro.org/bartosz_golaszewski/linux/-/tree/b4/sc8280xp-pwrseq?ref_type=heads
> [2] https://git.codelinaro.org/bartosz_golaszewski/linux/-/tree/sc8280xp-pwrseq-on-jhovold?ref_type=heads

Thanks for the quick response!  With everything in place, this does
seem to allow both wifi and bluetooth to continue to work on my
Thinkpad X13s
Tested-by: Steev Klimaszewski <steev@...i.org> #Thinkpad X13s