linux-kernel - Re: [PATCH] speakup: genmap: remove redundant post-increment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240813070828.65yluzkszaurva5f@begin>
Date: Tue, 13 Aug 2024 09:08:28 +0200
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: bajing <bajing@...s.chinamobile.com>
Cc: w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
	speakup@...ux-speakup.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] speakup: genmap: remove redundant post-increment

bajing, le mar. 13 août 2024 11:17:53 +0800, a ecrit:
> In the while loop, the variable lc is unused and is reinitialized later, so this redundant operation should be removed.
> 
> Signed-off-by: bajing <bajing@...s.chinamobile.com>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

> ---
>  drivers/accessibility/speakup/genmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..836276327bdd 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -72,7 +72,6 @@ main(int argc, char *argv[])
>  
>  	open_input(NULL, argv[1]);
>  	while (fgets(buffer, sizeof(buffer), infile)) {
> -		lc++;
>  		value = shift_state = 0;
>  
>  		cp = strtok(buffer, delims);
> -- 
> 2.33.0