linux-kernel - Re: [PATCH] platform/surface: aggregator: Fix warning when controller is destroyed in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172353729019.2056.10875402139846681143.b4-ty@linux.intel.com>
Date: Tue, 13 Aug 2024 11:21:30 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Hans de Goede <hdegoede@...hat.com>, 
 Maximilian Luz <luzmaximilian@...il.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/surface: aggregator: Fix warning when
 controller is destroyed in probe

On Sun, 11 Aug 2024 14:46:44 +0200, Maximilian Luz wrote:

> There is a small window in ssam_serial_hub_probe() where the controller
> is initialized but has not been started yet. Specifically, between
> ssam_controller_init() and ssam_controller_start(). Any failure in this
> window, for example caused by a failure of serdev_device_open(),
> currently results in an incorrect warning being emitted.
> 
> In particular, any failure in this window results in the controller
> being destroyed via ssam_controller_destroy(). This function checks the
> state of the controller and, in an attempt to validate that the
> controller has been cleanly shut down before we try and deallocate any
> resources, emits a warning if that state is not SSAM_CONTROLLER_STOPPED.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/surface: aggregator: Fix warning when controller is destroyed in probe
      commit: bc923d594db21bee0ead128eb4bb78f7e77467a4

--
 i.