linux-kernel - Re: [PATCH v2] ALSA: ASoC/tas2781: fix wrong calibrated data order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrsX_ry6bgDZB6bB@smile.fi.intel.com>
Date: Tue, 13 Aug 2024 11:23:26 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shenghao Ding <shenghao-ding@...com>
Cc: broonie@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com, 13564923607@....com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com, cameron.berkenpas@...il.com,
	tiwai@...e.de, baojun.xu@...com, soyer@....hu, Baojun.Xu@....com,
	robinchen@...com
Subject: Re: [PATCH v2] ALSA: ASoC/tas2781: fix wrong calibrated data order

On Tue, Aug 13, 2024 at 12:37:48PM +0800, Shenghao Ding wrote:
> From: Baojun Xu <baojun.xu@...com>
> 
> Wrong calibration data order cause sound too low in some device.
> Fix wrong calibrated data order, add calibration data converssion
> by get_unaligned_be32() after reading from UEFI.

...

>  			rc = tasdevice_dev_bulk_write(tas_priv, i,
>  				TASDEVICE_REG(0, page_array[j], rgno_array[j]),
> -				&(data[4 * j]), 4);
> +				(unsigned char *)&data, 4);

Casting is not needed if the helper is written in a way how regmap IO accessors
done.

In any case, 4 is sizeof(data)

> +			offset += 4;

Ditto.

-- 
With Best Regards,
Andy Shevchenko