linux-kernel - Re: [PATCH v5 01/12] dt-bindings: PCI: Cleanup of brcmstb YAML and add 7712 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5b0e395-7f2b-4dca-9764-83d0878e99c6@kernel.org>
Date: Tue, 13 Aug 2024 10:27:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jim Quinlan <james.quinlan@...adcom.com>
Cc: linux-pci@...r.kernel.org, Nicolas Saenz Julienne <nsaenz@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
 Cyril Brulebois <kibi@...ian.org>, Stanimir Varbanov <svarbanov@...e.de>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 bcm-kernel-feedback-list@...adcom.com, jim2101024@...il.com,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
 <linux-arm-kernel@...ts.infradead.org>,
 "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
 <linux-rpi-kernel@...ts.infradead.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 01/12] dt-bindings: PCI: Cleanup of brcmstb YAML and
 add 7712 SoC

On 13/08/2024 00:07, Jim Quinlan wrote:
> On Fri, Aug 2, 2024 at 2:43 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 01/08/2024 00:28, Jim Quinlan wrote:
>>> o Change order of the compatible strings to be alphabetical
>>> o Use "maxItems" where needed.
>>
>> I asked at v3 and then in v4 about splitting this. You never responded
>> to that comment, so sorry I won't be repeating the same thing in v5.
> 
> I'm sorry Krzyszof, but I just reviewed your responses in V3 and V4
> and I can't find you saying anything about splitting off the above two
> bullet points.  Perhaps I am somehow losing email responses but all I
> see is this in V3 is the following, where you ask me to do a squash,
> not a commit:
> 
>     [JQ] o Change order of the compatible strings to be alphabetical
>     []KK] That's a cleanup. You can squash it with a previous patch.
> 
> Now you did say in V3
> 
>     [JQ] o Describe resets/reset-names before using them in rules
>     [KK] That's a new commit.
> 
> but this bullet item does not relate to the bullet points you have
> highlighted in this email.    As for your responses to V4, I don't see

It exactly relates to the quoted part. The comment is ALWAYS under exact
part of your patch being questioned/commented.

So first I said one part is cleanup and should be moved away. Then I
explained that this part is a NEW COMMIT. New, so one more, different.

I understand that this was not clear, but you never came with a question
what did I mean.

Best regards,
Krzysztof