linux-kernel - Re: [PATCH v1 1/2] irqdomain: Unify checks for bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o75wrff7.ffs@tglx>
Date: Tue, 13 Aug 2024 10:32:44 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-kernel@...r.kernel.org
Cc: Herve Codina <herve.codina@...tlin.com>, Matti Vaittinen
 <mazziesaccount@...il.com>, Mark Brown <broonie@...nel.org>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/2] irqdomain: Unify checks for bus_token

On Mon, Aug 12 2024 at 22:29, Andy Shevchenko wrote:
> The code uses if (bus_token) and if (bus_token == DOMAIN_BUS_ANY).
> Since bus_token is enum, the later is more robust against changes.
> Unify all checks to follow the latter variant.
>
> Fixes: 0b21add71bd9 ("irqdomain: Handle domain bus token in irq_domain_create()")
> Fixes: 1bf2c9282927 ("irqdomain: Cleanup domain name allocation")

I'm fine with the change per se, but what does this fix? It's correct
code, no?