[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b1ab67c5-f465-4b0e-9104-a5b15c2fa724@kernel.org>
Date: Tue, 13 Aug 2024 10:55:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Richard Zhu <hongxing.zhu@....com>, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, shawnguo@...nel.org, l.stach@...gutronix.de
Cc: devicetree@...r.kernel.org, linux-pci@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel@...gutronix.de, imx@...ts.linux.dev
Subject: Re: [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for
i.MX8MQ PCIe EP
On 13/08/2024 10:54, Krzysztof Kozlowski wrote:
> On 13/08/2024 09:42, Richard Zhu wrote:
>> Add dbi2 and iatu reg for i.MX8MQ PCIe EP.
>>
>> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
>> driver. This method is not good.
>>
>> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
>> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
>> preparation to do that for i.MX8MQ PCIe EP.
>>
>> These changes wouldn't break driver function. When "dbi2" and "atu"
>> properties are present, i.MX PCIe driver would fetch the according base
>> addresses from DT directly. If only two reg properties are provided, i.MX
>> PCIe driver would fall back to the old method.
>>
>> Signed-off-by: Richard Zhu <hongxing.zhu@....com>
>> Reviewed-by: Frank Li <Frank.Li@....com>
>
> Stop adding fake tags. This never happened. If it happened, provide lore
> link.
>
Ah, my bad, now I see it. It's fine, sorry.
Best regards,
Krzysztof
Powered by blists - more mailing lists