linux-kernel - Re: [PATCH 1/2] dt-bindings: input: touchscreen: add Hynitron CST816X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02baff7e-845d-4f49-b2ce-ee06934786ab@kernel.org>
Date: Tue, 13 Aug 2024 11:15:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Oleh Kuzhylnyi <kuzhylol@...il.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, igor.opaniuk@...il.com,
 Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH 1/2] dt-bindings: input: touchscreen: add Hynitron CST816X

On 13/08/2024 01:22, Oleh Kuzhylnyi wrote:
> Add documentation for the Hynitron CST816X touchscreen bindings.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

How this could come with review tag if this is v1? Or is it not
correctly versioned?

That will confuse all the tools...

git format-patch -v2 or just use b4.


> Signed-off-by: Oleh Kuzhylnyi <kuzhylol@...il.com>

...

> +
> +properties:
> +  compatible:
> +    enum:
> +      - hynitron,cst816s
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +additionalProperties: false

If there is going to be new version, this goes after required: block.


Best regards,
Krzysztof