linux-kernel - Re: [PATCH v4 00/10] usb: gadget: uvc: effectively fill the udc isoc pipeline with available video buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024081345-radio-automatic-be9f@gregkh>
Date: Tue, 13 Aug 2024 12:01:58 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Daniel Scally <dan.scally@...asonboard.com>,
	Avichal Rakesh <arakesh@...gle.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 00/10] usb: gadget: uvc: effectively fill the udc isoc
 pipeline with available video buffers

On Tue, Aug 13, 2024 at 11:56:09AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2024 at 11:09:24AM +0200, Michael Grzeschik wrote:
> > This patch series is improving the size calculation and allocation of
> > the uvc requests. Using the selected frame duration of the stream it is
> > possible to calculate the number of requests based on the interval
> > length.
> > 
> > It also precalculates the request length based on the actual per frame
> > size for compressed formats.
> > 
> > For this calculations to work it was needed to rework the request
> > queueing by moving the encoding to one extra thread (in this case we
> > chose the qbuf) context.
> > 
> > Next it was needed to move the actual request enqueueing to one extra
> > thread which is kept busy to fill the isoc queue in the udc.
> > 
> > As a final step the series is increasing the minimum amount of
> > v4l2 buffers to 4 and allocates at least the amount of usb_requests
> > to store them in the usb gadgte isoc pipeline.
> > 
> > Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
> > ---
> > Changes in v4:
> > - fixed exit path in uvc_enqueue_buffer on loop break
> > - Link to v3: https://lore.kernel.org/r/20240403-uvc_request_length_by_interval-v3-0-4da7033dd488@pengutronix.de
> 
> I just took v3 in my tree, should I drop them?

Oops, emails crossed.  I'll go drop these now...

greg k-h