linux-kernel - Re: [PATCH v10 0/4] riscv: sophgo: Add SG2042 external hardware monitor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB282298A609327CDA62F5D43AFE862@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 13 Aug 2024 10:05:52 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...look.com>, Jean Delvare <jdelvare@...e.com>,
 Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Guo Ren <guoren@...nel.org>, Chao Wei <chao.wei@...hgo.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Drew Fustini <dfustini@...libre.com>, Sunil V L <sunilvl@...tanamicro.com>,
 Hal Feng <hal.feng@...rfivetech.com>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v10 0/4] riscv: sophgo: Add SG2042 external hardware
 monitor support


On 2024/8/13 9:53, Inochi Amaoto wrote:
> On Tue, Aug 13, 2024 at 09:24:19AM GMT, Chen Wang wrote:
>> On 2024/8/10 16:03, Inochi Amaoto wrote:
>>> Add support for the onboard hardware monitor for SG2042.
>>> Can be tested with OpenSBI v1.5.
>>>
>>> The patch require the following i2c patch:
>>> https://lore.kernel.org/all/IA1PR20MB4953DB82FB7D75BF8409FFF4BBB72@IA1PR20MB4953.namprd20.prod.outlook.com/
>>>
>>> Changed from v9:
>>> 1. remove missed wrong return value.
>>> 2. add documentation for the other interface of the driver.
>>> 3. rename repower_action to repower_policy.
>>> 4. use break to unify "return 0" in is_visible function.
>>>
>>> Changed from v8:
>>> 1. rename critical_action to repower_action, and add some comment
>>> 2. remove unnecessary wrap function
>>> 3. use guard macro to simplify mutex process.
>>>
>>> Changed from v7:
>>> 1. add mutex protected and fix the return value when writing
>>> "critical_action"
>>>
>>> Changed from v6:
>>> 1. restore the driver name to sg2042-mcu
>>> 2. remove unnecessary wrap function and check in the driver.
>>> 3. add dts and config entry.
>>>
>>> Changed from v5:
>>> 1. rename driver name to sgmcu as it will support more sophgo chip.
>>> 2. move some attr to debugfs.
>>> 3. add standard crit_hyst support
>>> 4. add documentation
>>>
>>> Changed from v4:
>>> 1. use fix patch for binding ref.
>>> 2. use unevaluatedProperties instead of additionalProperties for binding
>>>
>>> Changed from v3:
>>> 1. add thermal-sensor check.
>>> 2. change node type from syscon to hwmon
>>>
>>> Changed from v2:
>>> 1. fix bindings id path.
>>>
>>> Changed from v1:
>>> 1. Move patch from soc to hwmon.
>>> 2. Fix typo.
>>>
>>> Inochi Amaoto (4):
>>>     dt-bindings: hwmon: Add Sophgo SG2042 external hardware monitor
>>>       support
>>>     drivers: hwmon: sophgo: Add SG2042 external hardware monitor support
>>>     riscv: dts: sophgo: Add mcu device for Milk-V Pioneer
>>>     riscv: defconfig: Enable MCU support for SG2042
>>>
>>>    .../hwmon/sophgo,sg2042-hwmon-mcu.yaml        |  43 ++
>>>    Documentation/hwmon/index.rst                 |   1 +
>>>    Documentation/hwmon/sg2042-mcu.rst            |  77 ++++
>>>    .../boot/dts/sophgo/sg2042-milkv-pioneer.dts  |  60 +++
>>>    arch/riscv/configs/defconfig                  |   1 +
>>>    drivers/hwmon/Kconfig                         |  11 +
>>>    drivers/hwmon/Makefile                        |   1 +
>>>    drivers/hwmon/sg2042-mcu.c                    | 388 ++++++++++++++++++
>>>    8 files changed, 582 insertions(+)
>>>    create mode 100644 Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml
>>>    create mode 100644 Documentation/hwmon/sg2042-mcu.rst
>>>    create mode 100644 drivers/hwmon/sg2042-mcu.c
>>>
>>>
>>> base-commit: d2d190621b60d77496d36659e1621b20c897b25d
>>> prerequisite-patch-id: 5e7221ed1c63bb4d68e4a2a0141440e32d29e397
>> In fact, I did not find these two commit ids on master or sophgo/for-next.
>> When testing, I applied this patchset based on the latest sophgo/for-next.
> This two id comes from my tree, not the sophgo one. But I
> think it should be recognized by the git. For testing, you
> can just pick the sophgo/for-next tree and test it.
Don't use commit id from your local git, use public git so other people 
can find your base. Generally we use official label, such as 6.11-rc1.
>
> Regards,
> Inochi.