linux-kernel - Re: [PATCH] lib: Move KUnit tests into tests/ subdirectory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812202507.453bda6b@gandalf.local.home>
Date: Mon, 12 Aug 2024 20:25:07 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Kees Cook <kees@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Yury Norov
 <yury.norov@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, David
 Gow <davidgow@...gle.com>, "Jason A. Donenfeld" <Jason@...c4.com>, Andy
 Shevchenko <andy@...nel.org>, "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
 Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>, "David S. Miller"
 <davem@...emloft.net>, Masami Hiramatsu <mhiramat@...nel.org>, Mark Brown
 <broonie@...nel.org>, Matti Vaittinen <mazziesaccount@...il.com>,
 linux-hardening@...r.kernel.org, linux-kselftest@...r.kernel.org,
 kunit-dev@...glegroups.com, linux-trace-kernel@...r.kernel.org, Palmer
 Dabbelt <palmer@...osinc.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Charlie Jenkins <charlie@...osinc.com>,
 Simon Horman <horms@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Arnd
 Bergmann <arnd@...db.de>, Shuah Khan <skhan@...uxfoundation.org>, Daniel
 Latypov <dlatypov@...gle.com>, Guenter Roeck <linux@...ck-us.net>, David
 Howells <dhowells@...hat.com>, Mickaël Salaün
 <mic@...ikod.net>, Marco Elver <elver@...gle.com>, Mark Rutland
 <mark.rutland@....com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Vlastimil Babka <vbabka@...e.cz>, Geert Uytterhoeven
 <geert@...ux-m68k.org>, Nathan Chancellor <nathan@...nel.org>, Fangrui Song
 <maskray@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: Move KUnit tests into tests/ subdirectory

On Sat, 20 Jul 2024 11:10:30 -0700
Kees Cook <kees@...nel.org> wrote:

> Following from the recent KUnit file naming discussion[1], move all
> KUnit tests in lib/ into lib/tests/.
> 
> Link: https://lore.kernel.org/lkml/20240720165441.it.320-kees@kernel.org/ [1]
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---

Strong-Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

I was talking with Masami and asking him where the kunit test code lives
and after pointing to lib/ I was disgusted with what I saw. I told him,
"why isn't this in its own "tests/" directory"? And he mentioned this patch
(which I forgot about).

So yes, please move it.

Thanks,

-- Steve

> I can carry this in the hardening tree. To disrupt people as little as
> possible, I'm hoping to send this either at the end of -rc1 or early
> in -rc2.
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Yury Norov <yury.norov@...il.com>
> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
> Cc: David Gow <davidgow@...gle.com>
> Cc: "Jason A. Donenfeld" <Jason@...c4.com>
> Cc: Andy Shevchenko <andy@...nel.org>
> Cc: "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Matti Vaittinen <mazziesaccount@...il.com>
> Cc: linux-hardening@...r.kernel.org
> Cc: linux-kselftest@...r.kernel.org
> Cc: kunit-dev@...glegroups.com
> Cc: linux-trace-kernel@...r.kernel.org
>