[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zrs_YijPxKBFQF0_@smile.fi.intel.com>
Date: Tue, 13 Aug 2024 14:11:30 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Wolfram Sang <wsa@...nel.org>, Benson Leung <bleung@...omium.org>,
Tzung-Bi Shih <tzungbi@...nel.org>, Mark Brown <broonie@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
chrome-platform@...ts.linux.dev, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
Douglas Anderson <dianders@...omium.org>,
Johan Hovold <johan@...nel.org>, Jiri Kosina <jikos@...nel.org>,
linux-i2c@...r.kernel.org
Subject: Re: [PATCH v4 1/6] of: dynamic: Add of_changeset_update_prop_string
On Thu, Aug 08, 2024 at 05:59:24PM +0800, Chen-Yu Tsai wrote:
> Add a helper function to add string property updates to an OF changeset.
> This is similar to of_changeset_add_prop_string(), but instead of adding
> the property (and failing if it exists), it will update the property.
>
> This shall be used later in the DT hardware prober.
...
> +int of_changeset_update_prop_string(struct of_changeset *ocs,
> + struct device_node *np,
> + const char *prop_name, const char *str)
> +{
> + struct property prop;
> +
> + prop.name = (char *)prop_name;
> + prop.length = strlen(str) + 1;
> + prop.value = (void *)str;
Is it the existing style in the file? Otherwise I often see style like this
struct property prop = {
.name = (char *)prop_name;
.length = strlen(str) + 1;
.value = (void *)str;
};
in the kernel (IRQ domain, platform core, ...).
> + return of_changeset_update_prop_helper(ocs, np, &prop);
> +}
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists