linux-kernel - Re: [PATCH] firmware: arm_scmi: Update various protocols versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240813112237.drwgvhor3eisaj6t@lcpd911>
Date: Tue, 13 Aug 2024 16:52:37 +0530
From: Dhruva Gole <d-gole@...com>
To: Cristian Marussi <cristian.marussi@....com>
CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <arm-scmi@...r.kernel.org>, <sudeep.holla@....com>
Subject: Re: [PATCH] firmware: arm_scmi: Update various protocols versions

On Aug 12, 2024 at 18:40:27 +0100, Cristian Marussi wrote:
> A few protocol versions had been increased with SCMI v3.2.
> Update accordingly the supported version define in the kernel stack, since
> all the mandatory Base commands are indeed already supported.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> ---
>  drivers/firmware/arm_scmi/base.c    | 2 +-

I assume this patch supersedes [1] ?

[1] https://lore.kernel.org/arm-scmi/ZrZMLZq_-b9EFRgn@pluto/T/#t

>  drivers/firmware/arm_scmi/power.c   | 2 +-
>  drivers/firmware/arm_scmi/reset.c   | 2 +-
>  drivers/firmware/arm_scmi/sensors.c | 2 +-
>  drivers/firmware/arm_scmi/system.c  | 2 +-
>  drivers/firmware/arm_scmi/voltage.c | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c
> index 97254de35ab0..9939b1d84b7a 100644
> --- a/drivers/firmware/arm_scmi/base.c
> +++ b/drivers/firmware/arm_scmi/base.c
> @@ -14,7 +14,7 @@
>  #include "notify.h"
>  
>  /* Updated only after ALL the mandatory features for that version are merged */
> -#define SCMI_PROTOCOL_SUPPORTED_VERSION		0x20000
> +#define SCMI_PROTOCOL_SUPPORTED_VERSION		0x20001

Just curious, in upstream master TF-A I see 0x20000 still? [1]

[1] https://github.com/ARM-software/arm-trusted-firmware/blob/master/drivers/scmi-msg/base.h#L12


Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva