[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZrtCIU8On4ZKILmh@black.fi.intel.com>
Date: Tue, 13 Aug 2024 14:23:13 +0300
From: Raag Jadav <raag.jadav@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
rodrigo.vivi@...el.com, tursulin@...ulin.net, airlied@...il.com,
daniel@...ll.ch, linux@...ck-us.net, andi.shyti@...ux.intel.com,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
anshuman.gupta@...el.com, badal.nilawar@...el.com,
riana.tauro@...el.com, ashutosh.dixit@...el.com,
karthik.poosa@...el.com
Subject: Re: [PATCH v4] drm/i915/hwmon: expose fan speed
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
>
> > + /*
> > + * HW register value is accumulated count of pulses from
> > + * PWM fan with the scale of 2 pulses per rotation.
> > + */
> > + rotations = pulses >> 1;
>
> In accordance with the comment the
>
> rotations = pulses / 2;
>
> looks better.
This change seems to cause a build error in v5.
Something to do with __udivdi3 on i386.
Should we revert back to shift?
Found something similar here,
drivers/target/target_core_xcopy.c +697
Raag
Powered by blists - more mailing lists