linux-kernel - Re: [PATCH] ALSA: hda: cs35l41: Remove redundant call to hda_cs_dsp_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87le10myvj.wl-tiwai@suse.de>
Date: Tue, 13 Aug 2024 13:43:44 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: <tiwai@...e.com>,
	<linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<patches@...nsource.cirrus.com>
Subject: Re: [PATCH] ALSA: hda: cs35l41: Remove redundant call to hda_cs_dsp_control_remove()

On Tue, 13 Aug 2024 13:32:09 +0200,
Richard Fitzgerald wrote:
> 
> The driver doesn't create any ALSA controls for firmware controls, so it
> shouldn't be calling hda_cs_dsp_control_remove().
> 
> commit 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for
> firmware coefficients") removed the call to hda_cs_dsp_add_controls() but
> didn't remove the call for destroying those controls.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients")

Applied now.  Thanks.


Takashi