linux-kernel - Re: [PATCH v2 1/3] irqdomain: simplify simple and legacy domain creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f2474f2c-c1d8-4906-a777-be6ecc7b8016@app.fastmail.com>
Date: Tue, 13 Aug 2024 13:03:50 +0100
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Matti Vaittinen" <mazziesaccount@...il.com>,
 "Matti Vaittinen" <matti.vaittinen@...rohmeurope.com>,
 "Thomas Gleixner" <tglx@...utronix.de>
Cc: "Mark Brown" <broonie@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] irqdomain: simplify simple and legacy domain creation

在2024年8月13日八月 上午11:54，Matti Vaittinen写道：
[...]
>> This might be caused by drivers/irqchip/irq-mips-cpu.c has 
>> irq_domain_add_legacy() called with
>> first_irq set to 0.

>> 
>
> Right. Thanks for the report! I do appreciate this testing!
>
> first_irq gets assigned to the info->virq_base making it 0.
>
> Later, in the __irq_domain_instantiate() we use the info->virq_base as a 
> condition for
> 	if (info->virq_base > 0)
>                  irq_domain_associate_many()
> which was previously unconditionally called in the irq_domain_add_legacy().

Thanks for troubleshooting!

For those who want an easy reproducer on QEMU (9.0.2):

make ARCH=mips CROSS_COMPILE=mips64-linux- 64r6el_defconfig
make ARCH=mips CROSS_COMPILE=mips64-linux- -j8
qemu-system-mips64el -M boston -cpu I6500 -kernel ./vmlinux -append "console=ttyS0,115200" -nographic

Thanks

>
>> Do you have any idea on how should we fix it?
> Maybe we could add a flag for domain association similar to the "bool 
> cond_alloc_descs", but maybe Thomas has some better ideas...?
>
>
> Yours,
> 	-- Matti
> -- 
> Matti Vaittinen
> Linux kernel developer at ROHM Semiconductors
> Oulu Finland
>
> ~~ When things go utterly wrong vim users can always type :help! ~~

-- 
- Jiaxun