linux-kernel - Re: [PATCH] rtla: Sync the help text between hist tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP4=nvROfKr8s75B=POefQozE88se6zrfPcfaP_n5TqtXY9ABQ@mail.gmail.com>
Date: Tue, 13 Aug 2024 14:36:37 +0200
From: Tomas Glozar <tglozar@...hat.com>
To: Eder Zulian <ezulian@...hat.com>
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	rostedt@...dmis.org, jlelli@...hat.com, lgoncalv@...hat.com, 
	jkacur@...hat.com, williams@...hat.com
Subject: Re: [PATCH] rtla: Sync the help text between hist tools

út 13. 8. 2024 v 13:49 odesílatel Eder Zulian <ezulian@...hat.com> napsal:
>
> In addition, fix a typo in the error message generated when the
> specified duration is invalid.
>
> Signed-off-by: Eder Zulian <ezulian@...hat.com>
> ---
>  tools/tracing/rtla/src/osnoise_hist.c  | 4 ++--
>  tools/tracing/rtla/src/timerlat_hist.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>

FYI some of the issues you fixed for hist are also in timerlat_top.c:

        "      -d/--duration time[m|h|d]: duration of the session in seconds",
...
        case 'd':
            params->duration = parse_seconds_duration(optarg);
            if (!params->duration)
                timerlat_top_usage("Invalid -D duration\n");
            break;

and the "Invalid -D duration" (instead of "-d") one is also in
osnoise_top.c. Those would probably go to a separate patch, though.

Reviewed-by: Tomas Glozar <tglozar@...hat.com>


Tomas