linux-kernel - Re: [PATCH v3] usb: gadget: f_uac1: Change volume name and remove alt names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB0kiB+ONUpx9Ozg9x836BEdCtSSm-J+jpy2BKoDgVF1CP9O9Q@mail.gmail.com>
Date: Tue, 13 Aug 2024 08:56:26 -0400
From: Chris Wulff <crwulff@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org, Lee Jones <lee@...nel.org>, 
	Jeff Johnson <quic_jjohnson@...cinc.com>, Perr Zhang <perr@...7.net>, 
	Pavel Hofman <pavel.hofman@...tera.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] usb: gadget: f_uac1: Change volume name and remove alt names

On Tue, Aug 13, 2024 at 4:34 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Sat, Aug 03, 2024 at 08:29:13PM -0400, crwulff@...il.com wrote:
> > From: Chris Wulff <crwulff@...il.com>
> >
> > This changes the UAPI to align with disussion of alt settings work.
> >
> > fu_name is renamed to fu_vol_name, and alt settings mode names
> > are removed for now in favor of future work where they will be
> > settable in subdirectories for each alt mode.
> >
> > discussion thread for api changes for alt mode settings:
> > https://lore.kernel.org/linux-usb/35be4668-58d3-894a-72cf-de1afaacae45@ivitera.com/T/
>
> What is now going to break due to this change?  What userspace tools use
> the old names that need to be changed?
>
> Are you _SURE_ that you can rename external files like this and
> everything will keep on working?

Nothing is using them, since they were just introduced. I wanted to get
the API changed before they make it to mainline and somebody starts
using them.

You just applied the patch that introduced them into usb-next on 7/31/2024,
just after v6.11-rc1 so they haven't yet made it to the mainline kernel.

This is the patch that introduces them:

https://lore.kernel.org/all/CO1PR17MB541911B0C80D21E4B575E48CE1112@CO1PR17MB5419.namprd17.prod.outlook.com/

>
> thanks,
>
> greg k-h