linux-kernel - [PATCH 4/4] media: i2c: ov4689: Implement 2x2 binning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240813124443.446703-1-changhuang.liang@starfivetech.com>
Date: Tue, 13 Aug 2024 05:44:43 -0700
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: mike.rudenko@...il.com
Cc: christophe.jaillet@...adoo.fr,
	dave.stevenson@...pberrypi.com,
	jacopo@...ndi.org,
	laurent.pinchart@...asonboard.com,
	linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	mchehab@...nel.org,
	sakari.ailus@...ux.intel.com,
	tomm.merciai@...il.com,
	changhuang.liang@...rfivetech.com
Subject: [PATCH 4/4] media: i2c: ov4689: Implement 2x2 binning

Hi, Mikhail

Thanks for your patch.

>
> Implement 2x2 binning support. Compute best binning mode (none or 2x2)
> from pad crop and pad format in ov4689_set_fmt. Use output frame size
> instead of analogue crop to compute control ranges and BLC anchors.
>
> Also move ov4689_hts_min and ov4689_update_ctrl_ranges, since they are
> now also called from ov4689_set_fmt. Update frame timings to
> accommodate the requirements of binning mode and avoid visual
> artefacts. Additionally, report 2x2 binned mode in addition to
> non-binned one in ov4689_enum_frame_sizes.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@...il.com>

Tested-by: Changhuang Liang <changhuang.liang@...rfivetech.com>

> ---
>  drivers/media/i2c/ov4689.c | 179 ++++++++++++++++++++++++-------------
>  1 file changed, 117 insertions(+), 62 deletions(-)
>
> diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
> index c4c7c462672a..1499fbe88b76 100644
> --- a/drivers/media/i2c/ov4689.c
> +++ b/drivers/media/i2c/ov4689.c
> @@ -114,7 +114,7 @@
>   * Minimum working vertical blanking value. Found experimentally at
>   * minimum HTS values.
>   */

Regards,
Changhuang