linux-kernel - RE: [PATCH v8 1/4] rpmb: add Replay Protected Memory Block (RPMB) subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH7PR11MB7605877E4EE14DB19CBB26F0E5862@PH7PR11MB7605.namprd11.prod.outlook.com>
Date: Tue, 13 Aug 2024 13:07:07 +0000
From: "Winkler, Tomas" <tomas.winkler@...el.com>
To: Jens Wiklander <jens.wiklander@...aro.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"op-tee@...ts.trustedfirmware.org" <op-tee@...ts.trustedfirmware.org>, "Ulf
 Hansson" <ulf.hansson@...aro.org>, Shyam Saini
	<shyamsaini@...ux.microsoft.com>, Linus Walleij <linus.walleij@...aro.org>,
	Jerome Forissier <jerome.forissier@...aro.org>, Sumit Garg
	<sumit.garg@...aro.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, Bart
 Van Assche <bvanassche@....org>, Randy Dunlap <rdunlap@...radead.org>, Ard
 Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>, "Manuel Traut"
	<manut@...ka.net>, Mikko Rapeli <mikko.rapeli@...aro.org>,
	Alex Bennée <alex.bennee@...aro.org>
Subject: RE: [PATCH v8 1/4] rpmb: add Replay Protected Memory Block (RPMB)
 subsystem



> -----Original Message-----
> From: Jens Wiklander <jens.wiklander@...aro.org>
> Sent: Tuesday, August 13, 2024 3:13 PM
> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-kernel@...r.kernel.org; linux-mmc@...r.kernel.org; op-
> tee@...ts.trustedfirmware.org; Ulf Hansson <ulf.hansson@...aro.org>;
> Shyam Saini <shyamsaini@...ux.microsoft.com>; Linus Walleij
> <linus.walleij@...aro.org>; Jerome Forissier <jerome.forissier@...aro.org>;
> Sumit Garg <sumit.garg@...aro.org>; Ilias Apalodimas
> <ilias.apalodimas@...aro.org>; Bart Van Assche <bvanassche@....org>;
> Randy Dunlap <rdunlap@...radead.org>; Ard Biesheuvel
> <ardb@...nel.org>; Arnd Bergmann <arnd@...db.de>; Manuel Traut
> <manut@...ka.net>; Mikko Rapeli <mikko.rapeli@...aro.org>; Winkler,
> Tomas <tomas.winkler@...el.com>; Alex Bennée <alex.bennee@...aro.org>
> Subject: Re: [PATCH v8 1/4] rpmb: add Replay Protected Memory Block
> (RPMB) subsystem
> 
> On Tue, Aug 13, 2024 at 1:36 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Tue, Aug 13, 2024 at 01:26:18PM +0200, Jens Wiklander wrote:
> > > On Tue, Aug 13, 2024 at 11:29 AM Greg Kroah-Hartman
> > > <gregkh@...uxfoundation.org> wrote:
> > > >
> > > > On Mon, Aug 12, 2024 at 03:31:24PM +0200, Jens Wiklander wrote:
> > > > > --- /dev/null
> > > > > +++ b/drivers/misc/rpmb-core.c
> > > > > @@ -0,0 +1,233 @@
> > > > > +// SPDX-License-Identifier: GPL-2.0
> > > >
> > > > Fine, but:
> > > >
> > > > > --- /dev/null
> > > > > +++ b/include/linux/rpmb.h
> > > > > @@ -0,0 +1,136 @@
> > > > > +/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 */
> > > >
> > > > Really?
> > > >
> > > > Why?  I need lots of documentation and a lawyer sign off for why
> > > > this is a dual license for a file that is obviously only for
> > > > internal Linux kernel stuff.
> > >
> > > I'm sorry that was added via one of the patch sets before mine. I'll
> > > revert to GPL-2.0 only.
> >
> > Please be sure to get proper legal approval to change the license of
> > code not written by you :)
> 
> The dual license was introduced in
> https://lore.kernel.org/lkml/20220405093759.1126835-2-
> alex.bennee@...aro.org/,
> but https://lore.kernel.org/linux-mmc/1478548394-8184-2-git-send-email-
> tomas.winkler@...el.com/
> uses GPL-2.0 only. So reverting to GPL-2.0 only should be OK, don't you
> agree?


Ack.