linux-kernel - Re: [PATCH v4] drm/i915/hwmon: expose fan speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zrtag2qgxsCNiocc@smile.fi.intel.com>
Date: Tue, 13 Aug 2024 16:07:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
	rodrigo.vivi@...el.com, tursulin@...ulin.net, airlied@...il.com,
	daniel@...ll.ch, linux@...ck-us.net, andi.shyti@...ux.intel.com,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
	anshuman.gupta@...el.com, badal.nilawar@...el.com,
	riana.tauro@...el.com, ashutosh.dixit@...el.com,
	karthik.poosa@...el.com
Subject: Re: [PATCH v4] drm/i915/hwmon: expose fan speed

On Tue, Aug 13, 2024 at 03:53:25PM +0300, Raag Jadav wrote:
> On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote:
> > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:

...

> > > > > +	/*
> > > > > +	 * HW register value is accumulated count of pulses from
> > > > > +	 * PWM fan with the scale of 2 pulses per rotation.
> > > > > +	 */
> > > > > +	rotations = pulses >> 1;
> > > > 
> > > > In accordance with the comment the
> > > > 
> > > > 	rotations = pulses / 2;
> > > > 
> > > > looks better.
> > > 
> > > This change seems to cause a build error in v5.
> > > Something to do with __udivdi3 on i386.
> > 
> > No, it's not this change.
> > Please, read report carefully.
> 
> CI seems to point to DIV_ROUND_UP(), but it's been there since v1.
> So not sure if I entirely understand.

Yes, that's the issue. You always can reproduce on your side. LKP sent you
comprehensive information about their setup.

-- 
With Best Regards,
Andy Shevchenko