linux-kernel - Re: [PATCH 06/17] arm64: dts: layerscape: remove undocument big-endian in watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrzN2lQeMhJcGWHz@lizhi-Precision-Tower-5810>
Date: Wed, 14 Aug 2024 11:31:38 -0400
From: Frank Li <Frank.li@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Gregor Herburger <gregor.herburger@...tq-group.com>,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux@...tq-group.com
Subject: Re: [PATCH 06/17] arm64: dts: layerscape: remove undocument
 big-endian in watchdog

On Tue, Aug 13, 2024 at 01:00:42PM -0400, Frank Li wrote:
> On Tue, Aug 13, 2024 at 10:31:23AM +0200, Alexander Stein wrote:
> > Am Dienstag, 13. August 2024, 06:35:01 CEST schrieb Frank Li:
> > > Remove undocument property big-endian in watchdog.
> > > drivers/watchdog/imx2_wdt.c also never parser it.
> > >
> > > Fix below wanring:
> > > arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@...0000:
> > > 	Unevaluated properties are not allowed ('big-endian' was unexpected)
> > >
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
> > >  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
> > >  2 files changed, 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > index a3c57da63a01b..b84512bc4c881 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > @@ -430,7 +430,6 @@ wdog0: watchdog@...0000 {
> > >  			reg = <0x0 0x2ad0000 0x0 0x10000>;
> > >  			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > >  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(1)>;
> > > -			big-endian;
> >
> > RM LS1012A Rev3 10/2020 lists WDOG1 (2ad_0000) as big-endian.
>
> Thank you point this. I remember I run this last month, but not sure if
> 1012 platform. let me double check again.

I really thanks you for your careful review. I dump reset value of one
watch dog at 1043 platform.

0x02A80000:  00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 00

It is big endian.

Frank

>
> Frank
> >
> > >  		};
> > >
> > >  		sai1: sai@...0000 {
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > > index c0e3e8fa1e794..5837f1b15dccb 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > > @@ -776,7 +776,6 @@ wdog0: watchdog@...0000 {
> > >  			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > >  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> > >  					    QORIQ_CLK_PLL_DIV(1)>;
> > > -			big-endian;
> >
> > RM LS1043A Rev6 07/2020 lists WDOG1 (2ad_0000) as big-endian.
> >
> > What about ls1021a? According to RM this is also big-endian.
> > regmap_get_val_endian() parses this property and regmap is used
> > by drivers/watchdog/imx2_wdt.c
> >
> > Best regards,
> > Alexander
> >
> >
> > >  		};
> > >
> > >  		edma0: dma-controller@...0000 {
> > >
> > >
> >
> >
> > --
> > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > Amtsgericht München, HRB 105018
> > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > http://www.tq-group.com/
> >
> >