linux-kernel - Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5DOUbhKHOfX0z+hV0KtCsqN0ta=S1U64QXKNSExHbM_Kw@mail.gmail.com>
Date: Wed, 14 Aug 2024 13:27:32 -0300
From: Fabio Estevam <festevam@...il.com>
To: Frank Li <Frank.li@....com>
Cc: Guenter Roeck <linux@...ck-us.net>, Krzysztof Kozlowski <krzk@...nel.org>, 
	Animesh Agarwal <animeshagarwal28@...il.com>, Daniel Baluta <daniel.baluta@....com>, 
	Wim Van Sebroeck <wim@...ux-watchdog.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, linux-watchdog@...r.kernel.org, 
	devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing
 'big-endian' property

On Wed, Aug 14, 2024 at 12:37 PM Frank Li <Frank.li@....com> wrote:

> After Alexander Stein point out, check spec, and dump watch dog reset value
> at ls1043a platform.
>
> 0x02A80000:  00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
>
> It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
> to handle endian.
>
> So this change is corret.
>
> Reviewed-by: Frank Li <Frank.Li@....com>

Shouldn't 'big-endian: true' be conditionally enabled only for the
Layerscape platforms?