linux-kernel - Re: [PATCH v2 0/1] binfmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172365478431.4159848.371478248517217096.b4-ty@kernel.org>
Date: Wed, 14 Aug 2024 09:59:47 -0700
From: Kees Cook <kees@...nel.org>
To: akpm@...ux-foundation.org,
	jannh@...gle.com,
	sroettger@...gle.com,
	adhemerval.zanella@...aro.org,
	ojeda@...nel.org,
	adobriyan@...il.com,
	Kees Cook <kees@...nel.org>,
	jeffxu@...omium.org
Cc: linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	jorgelo@...omium.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 0/1] binfmt_elf: seal address zero

On Tue, 06 Aug 2024 21:49:26 +0000, jeffxu@...omium.org wrote:
> From: Jeff Xu <jeffxu@...omium.org>
> 
> In load_elf_binary as part of the execve(),  when the current
> task’s personality has MMAP_PAGE_ZERO set, the kernel allocates
> one page at address 0. According to the comment:
> 
> /* Why this, you ask???  Well SVr4 maps page 0 as read-only,
>     and some applications "depend" upon this behavior.
>     Since we do not have the power to recompile these, we
>      emulate the SVr4 behavior. Sigh. */
> 
> [...]

I added the cover letter details to the commit log and changed pr_warn()
to pr_warn_ratelimited(), but otherwise, looked good.

Applied to for-next/execve, thanks!

[1/1] binfmt_elf: mseal address zero
      https://git.kernel.org/kees/c/44f65d900698

Take care,

-- 
Kees Cook