linux-kernel - [PATCH] tools build: Provide consistent build options for fixdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240814173021.3726785-1-agordeev@linux.ibm.com>
Date: Wed, 14 Aug 2024 19:30:21 +0200
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Brian Norris <briannorris@...omium.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Cc: linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org, bpf@...r.kernel.org
Subject: [PATCH] tools build: Provide consistent build options for fixdep

The fixdep binary is being compiled and linked in one step since commit
ea974028a049 ("tools build: Avoid circular .fixdep-in.o.cmd issues").
While the host linker flags are passed to the compiler the host compiler
flags are missed.

That might lead to failures as result of the compiler vs linker flags
inconsistency. For example, during RPM package build redhat-hardened-ld
script is provided to gcc, while redhat-hardened-cc1 script is missed.
That leads to an error on s390:

/usr/bin/ld: /tmp/ccUT8Rdm.o: `stderr@@GLIBC_2.2' non-PLT reloc for
symbol defined in shared library and accessed from executable (rebuild
file with -fPIC ?)

Provide both KBUILD_HOSTCFLAGS and KBUILD_HOSTLDFLAGS to avoid that.

Signed-off-by: Alexander Gordeev <agordeev@...ux.ibm.com>
---

This patch is against kernel-next next-20240814 tag

---
 tools/build/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/build/Makefile b/tools/build/Makefile
index fea3cf647f5b..18ad131f6ea7 100644
--- a/tools/build/Makefile
+++ b/tools/build/Makefile
@@ -44,4 +44,4 @@ ifneq ($(wildcard $(TMP_O)),)
 endif

 $(OUTPUT)fixdep: $(srctree)/tools/build/fixdep.c
-	$(QUIET_CC)$(HOSTCC) $(KBUILD_HOSTLDFLAGS) -o $@ $<
+	$(QUIET_CC)$(HOSTCC) $(KBUILD_HOSTCFLAGS) $(KBUILD_HOSTLDFLAGS) -o $@ $<
-- 
2.43.0