linux-kernel - Re: [PATCH] reboot: add missing break to switch statement for LINUX_REBOOT_CMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7bb6e1c5-8ab3-4d1f-9e34-d231f0684572@stanley.mountain>
Date: Wed, 14 Aug 2024 21:12:55 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Enno Onneken <ennoonneken@...look.de>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] reboot: add missing break to switch statement for
 LINUX_REBOOT_CMD_HALT

Please don't drop the lists from the CC.

To be honest, I wouldn't bother with this patch but lots of people send lots of
patches that I probably wouldn't send and I send patches that they wouldn't
send.

If you want to resend it that's fine, but the commit message should say
something like, "The break statement isn't required for after a do_exit() call,
because it is a __noreturn function.  However, other do_exit() paths in this
switch() statement have a break statement so it looks weird.  Let's make this
consistent.  This change has no effect on runtime."

regards,
dan carpenter